23 Apr
2017
23 Apr
'17
10:20 p.m.
On Sun, 2017-04-23 at 15:42 +0300, Andy Shevchenko wrote:
On Sun, Apr 23, 2017 at 1:29 PM, Winkler, Tomas <tomas.winkler@intel. com> wrote:
New helpers take pointers to uuid_{be|le} as parameters.
When using them on a raw data we don't need to do an ugly dereference and, in some cases, a type casting.
I think this going overboard, the _pp types are just enough.
I looked at existing users and there are cases like #define XXX_UUID UUID_...(a, b, c, ...)
uuid_.*_cmp(value, XXX_UUID)
For _pp variant if would be _cmp_pp(value, &XXX_UUID) which is slightly worse than for _p variant.
Maybe it's worth to actually replace the defines with variables than to create an interface with all the permutations.
Tomas