Hi Dmitry,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pza/reset/next] [also build test WARNING on asoc/for-next linus/master v5.12-rc2 next-20210311] [cannot apply to tegra/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Dmitry-Osipenko/Add-missing-reset-c... base: https://git.pengutronix.de/git/pza/linux reset/next config: x86_64-randconfig-a011-20210311 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 574a9dabc63ba1e7a04c08d4bde2eacd61b44ce1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/082cad3274c4566ac97502fd137479791c31... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dmitry-Osipenko/Add-missing-reset-controls-to-NVIDIA-Tegra-ASoC-drivers/20210311-231938 git checkout 082cad3274c4566ac97502fd137479791c318300 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/reset/core.c:1013:6: warning: no previous prototype for function 'reset_control_bulk_put' [-Wmissing-prototypes]
void reset_control_bulk_put(int num_rstcs, struct reset_control_bulk_data *rstcs) ^ drivers/reset/core.c:1013:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void reset_control_bulk_put(int num_rstcs, struct reset_control_bulk_data *rstcs) ^ static 1 warning generated.
vim +/reset_control_bulk_put +1013 drivers/reset/core.c
1007 1008 /** 1009 * reset_control_bulk_put - free the reset controllers 1010 * @num_rstcs: number of entries in rstcs array 1011 * @rstcs: array of struct reset_control_bulk_data with reset controls set 1012 */
1013 void reset_control_bulk_put(int num_rstcs, struct reset_control_bulk_data *rstcs)
1014 { 1015 mutex_lock(&reset_list_mutex); 1016 while (num_rstcs--) { 1017 if (IS_ERR_OR_NULL(rstcs[num_rstcs].rstc)) 1018 continue; 1019 __reset_control_put_internal(rstcs[num_rstcs].rstc); 1020 } 1021 mutex_unlock(&reset_list_mutex); 1022 } 1023 EXPORT_SYMBOL_GPL(reset_control_bulk_put); 1024
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org