On 11/29/2022 5:24 PM, Mark Brown wrote:
On Fri, Nov 25, 2022 at 07:40:31PM +0100, Cezary Rojewski wrote:
From: Amadeusz Sławiński amadeuszx.slawinski@linux.intel.com
Following commits will make use of it to find codec DAI, define it first.
This breaks an x86 allmodconfig build:
/build/stage/linux/sound/soc/intel/avs/boards/rt5682.c: In function ‘avs_create_dai_link’: /build/stage/linux/sound/soc/intel/avs/boards/rt5682.c:198:20: error: ‘avs_rt5682_codec_exit’ undeclared (first use in this function); did you mean ‘avs_rt5682_codec_init’? 198 | dl->exit = avs_rt5682_codec_exit; | ^~~~~~~~~~~~~~~~~~~~~ | avs_rt5682_codec_init
and looks out of place in this commit, it at least deserves calling out in the commit log?
Oops.. that seems like patch split gone wrong, it is added in following commit. Other patches add dl->exit in the "second" patch, so this chunk should be part of patch 11, instead of this one.