Re: [PATCH] ASoC: max98088: add support for reg_4a_cfg_bypass reg

On Thu, May 12, 2022 at 11:12:02AM +0100, Mark Brown wrote:

On Thu, May 12, 2022 at 09:43:58AM +0200, Tommaso Merciai wrote:

...

Add mixer controls support for M98088_REG_4A_CFG_BYPASS register

...

+++ b/sound/soc/codecs/max98088.c @@ -486,6 +486,11 @@ static const struct snd_kcontrol_new max98088_snd_controls[] = { SOC_SINGLE("EQ1 Switch", M98088_REG_49_CFG_LEVEL, 0, 1, 0), SOC_SINGLE("EQ2 Switch", M98088_REG_49_CFG_LEVEL, 1, 1, 0),

•   SOC_SINGLE("SPK Bypass Switch", M98088_REG_4A_CFG_BYPASS, 0, 1, 0),
  

•   SOC_SINGLE("REC Bypass Switch", M98088_REG_4A_CFG_BYPASS, 1, 1, 0),
  

•   SOC_SINGLE("MIC2 Bypass Switch", M98088_REG_4A_CFG_BYPASS, 4, 1, 0),
  

•   SOC_SINGLE("INA Bypass Switch", M98088_REG_4A_CFG_BYPASS, 7, 1, 0),
  

These look like they should be DAPM controls since they're controlling audio routing but they're being added as regular controls.

Hi Mark, Thanks for the review, I'll send v2.

Tommaso