Hello Mark,
On 6/23/2012 4:31 PM, Mark Brown wrote:
On Thu, Jun 21, 2012 at 03:54:55PM +0530, Rajeev Kumar wrote:
- /* set codec DAI configuration */
- ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S |
SND_SOC_DAIFMT_CBS_CFM);You can se this in the dai_link structure rather than having to set it in hw_params() every time.
Ok, I will do that.
+static struct platform_driver spear_evb_driver = {
.driver = {.name = "spear-evb",.owner = THIS_MODULE,.pm =&snd_soc_pm_ops,},.probe = spear_evb_probe,.remove = __devexit_p(spear_evb_remove),+};
I'd expect to see an of_match_table in the device too given that you're parsing OF compatible data. Given how simple this is I wonder if you can instead add DT support to the simple-card driver which Morimoto-san recently contributed rather than adding a new driver?
I am not well-versed with device-tree framework. It will take me some time to study and incorporate the changes. I will get back on this point as soon as I finish the same.
In the meanwhile can I send the V3 of rest patches which is not applied, namely
1. [PATCH V2 1/9] sound:asoc: Add support for spdif in Audio Codec. 2. [PATCH V2 2/9] sound:asoc: Add support for STA529 Audio Codec. 3. [PATCH V2 6/9] sound:asoc:spdif_out: Add spdif out support
+MODULE_ALIAS("platform:spear evb");
This won't match against anything in the driver.
OK.
Best Regards Rajeev