On Thu, 24 Aug 2017 02:05:25 +0200, Tom Rini wrote:
On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
Not all devices with ACPI and this combination of sound devices will have the required information provided via ACPI. Reintroduce the I2C device ID to restore sound functionality on on the Chromebook 'Samus' model.
This is a regression from v4.12 on my laptop (a Chromebook 'Samus' that's not running ChromeOS). My fault for getting out of the habit of trying -rc1 when it comes out and not spotting this sooner. I'm not 100% sure if this fix is correct for all cases as I'm only able to test my hardware here, and this does fix my laptop.
Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data in the module sources") does not fix your issue?
As that's not in master yet I can't tell. Can you give me a pointer to somewhere? Thanks!
OK, my bad, it has a different hash upstream, but no, that change doesn't fix things as I see the problem on top of Linus' tree. Thanks!
Could you double-check? Your Oops likely comes from the NULL id->driver_type reference that is removed by the commit ddc9e69b9dc2.
If you still get an Oops, we need to decode it properly now to understand what's going on.
thanks,
Takashi