On 17/04/2023 18:27, Mark Brown wrote:
On Mon, Apr 17, 2023 at 06:00:59PM +0200, Krzysztof Kozlowski wrote:
On 17/04/2023 17:58, Mark Brown wrote:
You've replaced an unconditional dev_err() with dev_err_probe().
Which is the core of this change... so what is here surprising? Yes, that's functional change and I never wrote that dev_err_probe is equal dev_err. It is similar but offers benefits and one difference - does not print DEFER. Which is in general exactly what we want.
This may well be what you intended to do but it's not what the commit message says that the change is doing, unlike patch 1 this isn't an open coded dev_err_probe() that's being replaced.
But my patch 1 (and my other patches some time ago for wsa speakers) does exactly the same as this one here in few other places - introduces better message printing of EPROBE_DEFER. Only in one place it is equivalent.
If you prefer, I can mention the message/EPROBE_DEFER difference in commit msgs.
Best regards, Krzysztof