Re: [alsa-devel] [PATCH 2/4] DMA: PL330: Register the DMA controller with the generic DMA helpers

On Friday 18 January 2013, Padmavathi Venna wrote:

•   pfi = devm_kzalloc(&adev->dev, sizeof(*pfi), GFP_KERNEL);
  

•   if (!pfi) {
  

•           dev_err(&adev->dev, "unable to allocate mem\n");
  

•           return -ENOMEM;
  

•   }
  

•   pfi->dma_cap = pd->cap_mask;
  

•   pfi->filter_fn = pl330_filter;
  

•   ret = of_dma_controller_register(adev->dev.of_node,
  

•                                    of_dma_pl330_xlate, pfi);
  

Why do you pass a 'struct of_dma_filter_info' here? I would expect that you pass the pdmac object as the third argument.

Arnd