On 12/19/2013 12:20 PM, Takashi Iwai wrote:
At Thu, 19 Dec 2013 06:34:59 +0100, David Henningsson wrote:
On 12/18/2013 06:39 PM, Takashi Iwai wrote:
When a boost control influences on multiple input paths, we shouldn't pick up the name string specific to one input but rather choose a more generic name. A problem seen often is that a single mic boost controls both internal and external mics although the driver picks up the very first name randomly like "Internal Mic Boost". This should have been "Mic Boost", instead.
This patch tries to correct that behavior: when a boost control is available, check whether it conflicts with other inputs. If it does, use a common string ("Mic", "Line") as long as possible, or take a generic name "Input".
Hrm. I thought today "Mic Boost" is quite common, and meaning the mic boost of the non-internal mic. So I agree there is a problem - and thank you for trying to fix it - but isn't this just changing one problem for another? Now we don't know if a "Mic Boost" control controls the internal mic or not.
That's true, and the problem isn't new... I'm fine to use a different name as a boost control used for multiple mics, though. Spell your wish.
If *all* inputs go through the boost, then just preferring "Capture Boost" or "Input Boost" over "Mic Boost" would do the trick. I e, just skip the logic that checks for all inputs being of the same type.
The problem is when a boost controls two inputs but not the third. But since your code only looks through the input paths that go through the boost control and not the ones that don't, maybe we can save that problem for another day...