Re: [PATCH 39/49] gpio: sl28cpld: replace irqchip mask_invert with unmask_base

On Mon, Jun 20, 2022 at 10:10 PM Aidan MacDonald aidanmacdonald.0x0@gmail.com wrote:

An inverted mask register can be described more directly as an unmask register.

Reviewed-by: Andy Shevchenko andy.shevchenko@gmail.com

Signed-off-by: Aidan MacDonald aidanmacdonald.0x0@gmail.com

drivers/gpio/gpio-sl28cpld.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-sl28cpld.c b/drivers/gpio/gpio-sl28cpld.c index 52404736ac86..2195f88c2048 100644 --- a/drivers/gpio/gpio-sl28cpld.c +++ b/drivers/gpio/gpio-sl28cpld.c @@ -70,8 +70,7 @@ static int sl28cpld_gpio_irq_init(struct platform_device *pdev, irq_chip->num_irqs = ARRAY_SIZE(sl28cpld_gpio_irqs); irq_chip->num_regs = 1; irq_chip->status_base = base + GPIO_REG_IP;

•   irq_chip->mask_base = base + GPIO_REG_IE;
  

•   irq_chip->mask_invert = true;
  

•   irq_chip->unmask_base = base + GPIO_REG_IE;
    irq_chip->ack_base = base + GPIO_REG_IP;
  
    ret = devm_regmap_add_irq_chip_fwnode(dev, dev_fwnode(dev),
  

-- 2.35.1