13 Nov
2018
13 Nov
'18
6:32 p.m.
On Sun, 11 Nov 2018 20:02:45 +0100, Ayman Bagabas wrote:
Some of Huawei laptops come with a LED in the micmute key. This patch enables and disable this LED accordingly.
disable what?
This enables micmute LED for:
- Matebook X (19e5:3200), (19e5:3201)
- Matebook X Pro (19e5:3204)
Signed-off-by: Ayman Bagabas ayman.bagabas@gmail.com
The code changes are mostly OK. Just a minor nitpicking:
--- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5374,6 +5374,9 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec, /* for alc295_fixup_hp_top_speakers */ #include "hp_x360_helper.c"
+/* for alc_fixup_huawei_micmute_led */
This should be alc_fixup_huawei_wmi */
With that fix, Reviewed-by: Takashi Iwai tiwai@suse.de
thanks,
Takashi