Re: [alsa-devel] [PATCH v2 1/3] ASoC: rt5645: Simplify rt5645_enable_push_button_irq

On Tue, Jul 14, 2015 at 10:09:44AM +0000, Bard Liao wrote:

Thanks for the review. I think what we need is something like

• snd_soc_dapm_force_enable_pin(dapm, "ADC L power");
  

• snd_soc_dapm_force_enable_pin(dapm, "ADC R power");
  

• snd_soc_dapm_sync(dapm);
  

• if (!codec->component.card->instantiated) {
  

• 	regmap_update_bits(rt5645->regmap, RT5645_PWR_DIG1,
  

• 		RT5645_PWR_ADC_L_BIT | RT5645_PWR_ADC_R_BIT,
  

• 		RT5645_PWR_ADC_L_BIT | RT5645_PWR_ADC_R_BIT);
  

• }
  

Yes, that's more what I'd expect. You could probably just do the regmap update unconditionally since it shouldn't make any difference but it's a bit neater this way.