On Wed, Apr 17, 2019 at 11:40:28AM +0000, Derek wrote:
Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to.
The ones here with comments look an awful lot like they're system specific config which should be left up to either platform data (or DT/ACPI configuration) or done at runtime (like gains). Some of the others like the pads configuration might also fit into that.
We don't open the DA gain setting for user at runtime, so have to set a default level in the init list.
That's not the way Linux drivers generally work... is there some technical reason for that or is it just some kind of policy decision?
Maybe I could add a gain control for the user and set the gain to safety max level in init list for speaker protection.
+static void rt1308_reset(struct regmap *regmap) {
- regmap_write(regmap, RT1308_RESET, 0); }
If we do need the init list shouldn't we also do a reninit every time we do a
reset?
The init list is only set at driver probe, not every time after resetting.
This is what I'm pointing out; if you don't restore these values then why set them at all?
OK, I could reinit after every time resetting.
------Please consider the environment before printing this e-mail.