Hi Dylan,
Thanks for your patch. It looks good to me. I just have a small remark in the bindings. Also, I don't think that both bindinds and driver code should be on the same patch. You separate this into 2 patches...
From: Dylan Laduranty dylan.laduranty@mesotic.com Sent: Wednesday, May 11, 2022 10:34 PM To: alsa-devel@alsa-project.org Cc: Sa, Nuno Nuno.Sa@analog.com; Dylan Laduranty dylan.laduranty@mesotic.com Subject: [PATCH] ASoC: ADAU7118: add bindings for managing pins drive strength
This allows users to change SDATA and both PDM clocks pins drive strength during device probing according to their need.
Update yaml documentation accordingly.
Signed-off-by: Dylan Laduranty dylan.laduranty@mesotic.com
.../bindings/sound/adi,adau7118.yaml | 24 +++++++ sound/soc/codecs/adau7118.c | 62 +++++++++++++++++-- 2 files changed, 82 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml index fb78967ee17b..71e8a9ff2edf 100644 --- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml +++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml @@ -51,6 +51,27 @@ properties: maximum: 1 default: [0, 0, 1, 1]
- adi,pdm-clk0-ds:
- description: |
This property set the drive strength of PDM CLK0 output pad.- $ref: /schemas/types.yaml#/definitions/uint32
- enum: [3, 2, 1, 0]
- default: 2
- adi,pdm-clk1-ds:
- description: |
This property set the drive strength of PDM CLK1 output pad.- $ref: /schemas/types.yaml#/definitions/uint32
- enum: [3, 2, 1, 0]
- default: 2
- adi,sdata-ds:
- description: |
This property set the drive strength of SDATA output pad.- $ref: /schemas/types.yaml#/definitions/uint32
- enum: [3, 2, 1, 0]
- default: 2
It would be nice to state here what's the meaning of 3,2,1,0...
- Nuno Sá