Re: [alsa-devel] [PATCH 11/36] ARM: s5pv210: split from plat-samsung

On Thu, Oct 10, 2019 at 10:29:55PM +0200, Arnd Bergmann wrote:

These can be build completely independently, so split the two Kconfig symbols.

Signed-off-by: Arnd Bergmann arnd@arndb.de

I'd mention the two symbols' names you're working on in the commit log. I guess it's about PLAT_SAMSUNG and ARCH_S5PV210. And I wouldn't call it "split" which IMHO suggests there was only one symbol before.

Maybe:

Don't imply PLAT_SAMSUNG if ARCH_S5PV210 is enabled

would be a better subject line?

---

arch/arm/Kconfig.debug | 6 +++--- arch/arm/Makefile | 1 - arch/arm/plat-samsung/Kconfig | 2 +- drivers/mmc/host/Kconfig | 2 +- drivers/pwm/Kconfig | 2 +- drivers/spi/Kconfig | 2 +- drivers/tty/serial/Kconfig | 2 +- sound/soc/samsung/Kconfig | 2 +- 8 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 9c4f2d6deb06..4c4e97ae4fcb 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -998,7 +998,7 @@ choice via SCIFA4 on Renesas SH-Mobile AG5 (SH73A0).

config DEBUG_S3C_UART0

• depends on PLAT_SAMSUNG || ARCH_EXYNOS
  

• depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS
  

  select DEBUG_EXYNOS_UART if ARCH_EXYNOS select DEBUG_S3C24XX_UART if ARCH_S3C24XX select DEBUG_S3C64XX_UART if ARCH_S3C64XX

@@ -1010,7 +1010,7 @@ choice by the boot-loader before use.

config DEBUG_S3C_UART1

• depends on PLAT_SAMSUNG || ARCH_EXYNOS
  

• depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS
  

  select DEBUG_EXYNOS_UART if ARCH_EXYNOS select DEBUG_S3C24XX_UART if ARCH_S3C24XX select DEBUG_S3C64XX_UART if ARCH_S3C64XX

@@ -1022,7 +1022,7 @@ choice by the boot-loader before use.

config DEBUG_S3C_UART2

• depends on PLAT_SAMSUNG || ARCH_EXYNOS
  

• depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS
  

  select DEBUG_EXYNOS_UART if ARCH_EXYNOS select DEBUG_S3C24XX_UART if ARCH_S3C24XX select DEBUG_S3C64XX_UART if ARCH_S3C64XX

diff --git a/arch/arm/Makefile b/arch/arm/Makefile index f492d7c338fe..a1bc15cda751 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -235,7 +235,6 @@ machine-$(CONFIG_PLAT_SPEAR) += spear # by CONFIG_* macro name. plat-$(CONFIG_ARCH_OMAP) += omap plat-$(CONFIG_ARCH_S3C64XX) += samsung -plat-$(CONFIG_ARCH_S5PV210) += samsung

Would it make more sense to make this

plat-$(PLAT_SAMSUNG) += samsung

(in a separate patch)? Hmm, it seems there is no plat-y for PLAT_S3C24XX=y builds. Is this intended? If yes, the directory name containing "samsung" suggests something that seems untrue.

Best regards Uwe