Hi,
On May 7 2018 00:47, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@nxp.com
'snd_pcm_format_t' type is better suited for iterating through the SNDRV_PCM_FORMAT members.
Also, use SNDRV_PCM_FORMAT_FIRST for the first element.
Signed-off-by: Fabio Estevam fabio.estevam@nxp.com
sound/core/pcm_native.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
You use 'ASoC' prefix in titile of this patch, but...
$ git log --oneline sound/core/pcm_native.c ... 41412fe92118 ALSA: pcm: Change return type to vm_fault_t f853dcaae2f5 ALSA: core: Report audio_tstamp in snd_pcm_sync_ptr 912e4c332037 ALSA: pcm: Return negative delays from SNDRV_PCM_IOCTL_DELAY. c99c5a3bb575 ALSA: pcm: Unify delay calculation in snd_pcm_status() and snd_pcm_delay() 6448fcba2a7f ALSA: pcm: Unify playback and capture poll callbacks 763e5067aac9 ALSA: pcm: Clean up with snd_pcm_avail() and snd_pcm_hw_avail() helpers ...
It's better to use 'ALSA' prefix with 'pcm' or 'core' tag because your change is outside of ALSA SoC part and can affects whole PCM related stuffs. Furthermore, you need to post it to a maintainer of this subsystem as long as you'd like to request the maintainer to apply it.
Thanks
Takashi Sakamoto