On Wed, Mar 10, 2010 at 02:23:15PM +0000, Mark Brown wrote:
On Wed, Mar 10, 2010 at 04:48:55PM +0900, Jassi Brar wrote:
I have prepared some patches that debug and modify the behaviour of extant S3C I2S support towards managing I2Sv4 controllers as well.
OK, I think that's everything. I've not applied anything after the header move yet due to the need for an ack from Ben. Any patches I didn't specifically comment on are OK. Overall it's all good, most of the issues are minor.
I'd like to see a bit of header reformatting to make them readable if they're not already merged.
the header moves are ok by me, much prefer to see them git mv'd than copy and rm'd.
In future could you please use --no-chain-reply-to when sending patches to avoid massively deep threads in threaded mail readers (the git default is changing in 1.7.0 for this very reason). It's also best to send the cover letter first and tell git send-email that everything should be sent in reply to that - this way people are likely to see the cover letter before the patches.
agreed on this one.