Re: [alsa-devel] ASoC: 88pm860x: Question about pm860x_set_dai_sysclk implementation

On Sun, 2015-06-28 at 23:00 +0800, Axel Lin wrote:

Hi Haojian, In sound/soc/codecs/88pm860x-codec.c (pm860x_set_dai_sysclk): When dir != PM860X_CLK_DIR_OUT, current code set pm860x->dir = PM860X_CLK_DIR_IN; and then return -EINVAL. This looks confusion. Since there is no comment for that, I'm wondering if the return -EINVAL is intentional or not.

Regards, Axel

Hi Axel,

Since we didn't support slave mode in our solution, I just return -EINVAL for PM860X_CLK_DIR_IN. I'm sorry to add the confused code. Could you help to format a patch to add the comments?

Regards Haojian