On Thu, May 12, 2022 at 12:46:42PM +0200, Tommaso Merciai wrote:
On Thu, May 12, 2022 at 11:12:02AM +0100, Mark Brown wrote:
These look like they should be DAPM controls since they're controlling audio routing but they're being added as regular controls.
Sorry again. You suggest to create a new structure for these entries, for example:
/* Out Bypass mixer switch */ static const struct snd_kcontrol_new max98088_out_bypass_mixer_controls[] = { SOC_DAPM_SINGLE("INA Switch", M98088_REG_4A_CFG_BYPASS, 7, 1, 0), SOC_DAPM_SINGLE("MIC2 Switch", M98088_REG_4A_CFG_BYPASS, 4, 1, 0), SOC_DAPM_SINGLE("REC Switch", M98088_REG_4A_CFG_BYPASS, 1, 1, 0), SOC_DAPM_SINGLE("SPK Switch", M98088_REG_4A_CFG_BYPASS, 0, 1, 0), };
If that's how they fit into the routing for the device, yes - you'd need to define the bypass mixer as well and set up appropraite routes.