On 26-09-18, 11:23, Srinivas Kandagatla wrote:
This patch adds support to set runtime dma buffer on compressed stream.
The change is fine as is, but I feel we need to document the motivation in the changelog. The core changes need a bit more explanation on why we should add this..
Signed-off-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org
include/sound/compress_driver.h | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h index ea8c93bbb0e0..0cdc3999ecfa 100644 --- a/include/sound/compress_driver.h +++ b/include/sound/compress_driver.h @@ -23,6 +23,7 @@ struct snd_compr_ops;
- struct snd_compr_runtime: runtime stream description
- @state: stream state
- @ops: pointer to DSP callbacks
- @dma_buffer_p: runtime dma buffer pointer
- @buffer: pointer to kernel buffer, valid only when not in mmap mode or
- DSP doesn't implement copy
- @buffer_size: size of the above buffer
@@ -37,6 +38,7 @@ struct snd_compr_ops; struct snd_compr_runtime { snd_pcm_state_t state; struct snd_compr_ops *ops;
- struct snd_dma_buffer *dma_buffer_p; void *buffer; u64 buffer_size; u32 fragment_size;
@@ -175,6 +177,23 @@ static inline void snd_compr_drain_notify(struct snd_compr_stream *stream) wake_up(&stream->runtime->sleep); }
+/**
- snd_compr_set_runtime_buffer - Set the Compress runtime buffer
- @substream: compress substream to set
- @bufp: the buffer information, NULL to clear
- Copy the buffer information to runtime buffer when @bufp is non-NULL.
- Otherwise it clears the current buffer information.
- */
+static inline void snd_compr_set_runtime_buffer(
struct snd_compr_stream *substream,struct snd_dma_buffer *bufp)+{
- struct snd_compr_runtime *runtime = substream->runtime;
- runtime->dma_buffer_p = bufp;
+}
int snd_compr_stop_error(struct snd_compr_stream *stream, snd_pcm_state_t state);
-- 2.19.0