Thanks, I got the point, so the fix in snd_hdac_device_exit will resolve the issue completely.
Rander
-----Original Message----- From: Kai Vehmanen kai.vehmanen@linux.intel.com Sent: Friday, September 4, 2020 7:31 PM To: Takashi Iwai tiwai@suse.de; Wang, Rander rander.wang@intel.com Cc: Kai Vehmanen kai.vehmanen@linux.intel.com; alsa-devel@alsa- project.org; Ranjani Sridharan ranjani.sridharan@linux.intel.com; Pierre- Louis Bossart pierre-louis.bossart@linux.intel.com; Bard Liao <yung- chuan.liao@linux.intel.com>; Guennadi Liakhovetski guennadi.liakhovetski@linux.intel.com Subject: Re: [PATCH] ALSA: hda: release resource when snd_hdac_device_init is failed
Hey,
On Wed, 2 Sep 2020, Takashi Iwai wrote:
On Wed, 02 Sep 2020 17:42:29 +0200, Kai Vehmanen wrote:
When snd_hdac_device_init is failed, the codec is released by kfree immediately without releasing some resources. The vendor_name should
It's released via put_device() and this should call the release callback, default_release(), and it contains all those kfree()'s and pm_runtime_*().
Could you double-check whether it's really missing?
ack, thanks for spotting. put_device() indeed calls the default release, so this patch is not correct.
Rander, can you check as well this matches with the scenario you were looking at?
Br, Kai