Hello Morimoto-san
On Tue, 7 Sep 2010, Kuninori Morimoto wrote:
Reported-by: Guennadi Liakhovetski g.liakhovetski@gmx.de Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
You have not addressed all of my comments to your sh_mobile_hdmi.c patch and you have not explained, why you do not address them. On the whole, I am still in favour of reverting that original patch and redoing it.
Thanks Guennadi
drivers/video/sh_mobile_hdmi.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/video/sh_mobile_hdmi.c b/drivers/video/sh_mobile_hdmi.c index d51f751..a2d6f7b 100644 --- a/drivers/video/sh_mobile_hdmi.c +++ b/drivers/video/sh_mobile_hdmi.c @@ -974,7 +974,7 @@ static int __init sh_hdmi_probe(struct platform_device *pdev) ret = snd_soc_register_codec(&pdev->dev, &soc_codec_dev_sh_hdmi, &sh_hdmi_dai, 1); if (ret < 0)
goto egetclk;
goto esndreg;hdmi->dev = &pdev->dev;
@@ -1061,6 +1061,8 @@ eclkenable: erate: clk_put(hdmi->hdmi_clk); egetclk:
- snd_soc_unregister_codec(&pdev->dev);
+esndreg: kfree(hdmi);
return ret;
1.7.0.4
--- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/