27 Mar
2014
27 Mar
'14
3:29 a.m.
On Thu, Mar 27, 2014 at 01:14:24AM +0000, Mark Brown wrote:
On Wed, Mar 26, 2014 at 11:59:53AM +0000, David Laight wrote:
From: Nicolin Chen
- regmap_read(sai->regmap, FSL_SAI_TCSR, &xcsr);
- regmap_write(sai->regmap, FSL_SAI_TCSR, xcsr);
Assuming these are 'write to clear' bits, you might want to make the write (above) and all the traces (below) conditional on the value being non-zero.
The trace is already conditional? I'd also expect to see the driver only acknowledging sources it knows about and only reporting that the interrupt was handled if it saw one of them - right now all interrupts are unconditionally acknowleged.
Will revise it based on the comments from both of you.
Thank you.
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel