Re: [PATCH v6 0/2] Modify documentation and machine driver for SC7180 sound card

Hi, Mark

Could you please kindly review the series patch v6? And may I get your approval if the review is done.

thanks Ajye

On Fri, Nov 6, 2020 at 2:14 PM Ajye Huang ajye.huang@gmail.com wrote:

Note:

• The patch is made by the collaboration of

Ajye Huang ajye_huang@compal.corp-partner.google.com Cheng-Yi Chiang cychiang@chromium.org

v6:

• Documentation: Addressed suggestions from Rob Herring.
  • Define "maxItems: 1" in dmic-gpios property.
  • Only keep one example and add dmic-gpios property in.

v5:

• Machine driver:
  • Fix a format string warning (Reported-by: kernel test robot lkp@intel.com). detailed info at https://lore.kernel.org/patchwork/patch/1331087/

v4:

• Machine driver: Addressed suggestions from Tzung-Bi.
  • Remove redundant judgments in dmic_set() and dmic_get().
  • Remove 1 level indent of judgment of IS_ERR(data->dmic_sel).

v3:

• Machine driver: Addressed suggestions from Tzung-Bi.
  • Move variables "dmic_switch" and "dmic_sel" into struct sc7180_snd_data.
  • Remove redundant judgments in dmic_set().

v2:

• Documentation: Modify the dimc-gpios property description and examples.
• Machine driver:
  • Remove "qcom,sc7180-sndcard-rt5682-m98357-2mic" compatible
  • See gpio property and use anadditional control.

Thanks for the review!

Ajye Huang (2): ASoC: google: dt-bindings: modify machine bindings for two MICs case ASoC: qcom: sc7180: Modify machine driver for 2mic

.../bindings/sound/google,sc7180-trogdor.yaml | 8 ++- sound/soc/qcom/sc7180.c | 61 +++++++++++++++++++ 2 files changed, 68 insertions(+), 1 deletion(-)

-- 2.25.1