On Tue, 2023-03-14 at 13:33 +0100, Takashi Iwai wrote:
On Tue, 14 Mar 2023 13:12:08 +0100, Niklas Schnelle wrote:
--- a/sound/isa/Kconfig +++ b/sound/isa/Kconfig @@ -23,6 +23,7 @@ menuconfig SND_ISA bool "ISA sound devices" depends on ISA || COMPILE_TEST depends on ISA_DMA_API
- depends on HAS_IOPORT default y help Support for sound devices connected via the ISA bus.
With this dependency, ...
@@ -31,6 +32,7 @@ if SND_ISA
config SND_ADLIB tristate "AdLib FM card"
- depends on HAS_IOPORT select SND_OPL3_LIB help Say Y here to include support for AdLib FM cards.
... this and lots of other similar changes become redundant, as they already depend on CONFIG_SND_ISA.
Good point and semantically it makes sense too since ISA is closely associated with I/O ports.
--- a/sound/pcmcia/Kconfig +++ b/sound/pcmcia/Kconfig @@ -13,6 +13,7 @@ if SND_PCMCIA && PCMCIA config SND_VXPOCKET tristate "Digigram VXpocket" select SND_VX_LIB
- depends on HAS_IOPORT help Say Y here to include support for Digigram VXpocket and VXpocket 440 soundcards.
@@ -22,6 +23,7 @@ config SND_VXPOCKET
config SND_PDAUDIOCF tristate "Sound Core PDAudioCF"
- depends on HAS_IOPORT select SND_PCM help Say Y here to include support for Sound Core PDAudioCF
I guess it's easier to make CONFIG_SND_PCMCIA depending on CONFIG_HAS_IOPORT (like done for CONFIG_SND_ISA).
In principle I think there could be a MMIO based PCMCIA sound card but it appears there is none currently supported and I doubt someone adds one so yeah that makes sense even if it isn't as clear cut as with CONFIG_SND_ISA.
I've changed both vor v4. Thanks!