Hi Takashi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v5.12-rc4] [also build test WARNING on next-20210324] [cannot apply to sound/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Takashi-Iwai/ALSA-hda-Re-add-droppe... base: 0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/9d72f7bfcc53f9e360ceba244596818bb00f... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Takashi-Iwai/ALSA-hda-Re-add-dropped-snd_poewr_change_state/20210325-043958 git checkout 9d72f7bfcc53f9e360ceba244596818bb00f1f7d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
sound/pci/hda/hda_intel.c: In function 'azx_rescan_prepare': sound/pci/hda/hda_intel.c:2419:3: error: implicit declaration of function 'azx_prepare'; did you mean 'azx_create'? [-Werror=implicit-function-declaration] 2419 | azx_prepare(&pdev->dev); | ^~~~~~~~~~~ | azx_create sound/pci/hda/hda_intel.c:2427:3: error: implicit declaration of function 'azx_suspend' [-Werror=implicit-function-declaration] 2427 | azx_suspend(&pdev->dev); | ^~~~~~~~~~~ sound/pci/hda/hda_intel.c: In function 'azx_rescan_done': sound/pci/hda/hda_intel.c:2466:3: error: implicit declaration of function 'azx_resume'; did you mean 'azx_remove'? [-Werror=implicit-function-declaration] 2466 | azx_resume(&pdev->dev); | ^~~~~~~~~~ | azx_remove sound/pci/hda/hda_intel.c:2471:3: error: implicit declaration of function 'azx_complete'; did you mean 'complete'? [-Werror=implicit-function-declaration] 2471 | azx_complete(&pdev->dev); | ^~~~~~~~~~~~ | complete sound/pci/hda/hda_intel.c: At top level: sound/pci/hda/hda_intel.c:2845:3: error: 'struct pci_driver' has no member named 'rescan_prepare' 2845 | .rescan_prepare = azx_rescan_prepare, | ^~~~~~~~~~~~~~
sound/pci/hda/hda_intel.c:2845:20: warning: initialization of 'unsigned int' from 'void (*)(struct pci_dev *)' makes integer from pointer without a cast [-Wint-conversion]
2845 | .rescan_prepare = azx_rescan_prepare, | ^~~~~~~~~~~~~~~~~~ sound/pci/hda/hda_intel.c:2845:20: note: (near initialization for 'azx_driver.dynids.lock.<anonymous>.rlock.raw_lock.slock') sound/pci/hda/hda_intel.c:2846:3: error: 'struct pci_driver' has no member named 'rescan_done' 2846 | .rescan_done = azx_rescan_done, | ^~~~~~~~~~~
sound/pci/hda/hda_intel.c:2846:17: warning: excess elements in struct initializer
2846 | .rescan_done = azx_rescan_done, | ^~~~~~~~~~~~~~~ sound/pci/hda/hda_intel.c:2846:17: note: (near initialization for 'azx_driver') sound/pci/hda/hda_intel.c:2847:3: error: 'struct pci_driver' has no member named 'bar_fixed' 2847 | .bar_fixed = azx_bar_fixed, | ^~~~~~~~~ sound/pci/hda/hda_intel.c:2847:15: warning: excess elements in struct initializer 2847 | .bar_fixed = azx_bar_fixed, | ^~~~~~~~~~~~~ sound/pci/hda/hda_intel.c:2847:15: note: (near initialization for 'azx_driver')
sound/pci/hda/hda_intel.c:2835:39: warning: missing braces around initializer [-Wmissing-braces]
2835 | static struct pci_driver azx_driver = { | ^ ...... 2845 | .rescan_prepare = azx_rescan_prepare, | {{{{{ }}}}} In file included from include/linux/perf_event.h:25, from include/linux/trace_events.h:10, from include/trace/trace_events.h:21, from include/trace/define_trace.h:102, from sound/pci/hda/hda_intel_trace.h:54, from sound/pci/hda/hda_intel.c:59: arch/arc/include/asm/perf_event.h:126:23: warning: 'arc_pmu_cache_map' defined but not used [-Wunused-const-variable=] 126 | static const unsigned arc_pmu_cache_map[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = { | ^~~~~~~~~~~~~~~~~ arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map' defined but not used [-Wunused-const-variable=] 91 | static const char * const arc_pmu_ev_hw_map[] = { | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors
vim +2845 sound/pci/hda/hda_intel.c
2833 2834 /* pci_driver definition */
2835 static struct pci_driver azx_driver = {
2836 .name = KBUILD_MODNAME, 2837 .id_table = azx_ids, 2838 .probe = azx_probe, 2839 .remove = azx_remove, 2840 .shutdown = azx_shutdown, 2841 .driver = { 2842 .pm = AZX_PM_OPS, 2843 }, 2844 #ifdef CONFIG_PM
2845 .rescan_prepare = azx_rescan_prepare, 2846 .rescan_done = azx_rescan_done,
2847 .bar_fixed = azx_bar_fixed, 2848 #endif 2849 }; 2850
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org