Re: [alsa-devel] [PATCH v3] ASoC: Add support for cs42l73 codec

On Fri, Oct 07, 2011 at 04:37:16PM +0530, Vinod Koul wrote:

See below:

+static const struct snd_kcontrol_new dac1_output_mixer[] = {

•   SOC_DAPM_SINGLE("Headphone Switch", CS42L73_PWRCTL3, 0, 1, 1),
  

•   SOC_DAPM_SINGLE("LineOut Switch", CS42L73_PWRCTL3, 1, 1, 1),
  

+};

+static const struct snd_kcontrol_new dac2_output_mixer[] = {

•   SOC_DAPM_SINGLE("Speakerphone Switch", CS42L73_PWRCTL3, 2, 1,
  

1),

•   SOC_DAPM_SINGLE("Speakerphone LineOut Switch", CS42L73_PWRCTL3,
  

•                   4, 1, 1),
  

•   SOC_DAPM_SINGLE("EarSpeaker Switch", CS42L73_PWRCTL3, 3, 1, 1),
  

+};

I think naming should be slightly better :)

I'm not sure, it might be more than the naming. The fact that we're in PWRCTL registers could be confusing hardware design, or the structure of the hardware may not actually reflect what the driver is doing.