Re: [PATCH 4/4] ASoC: wm8994: Silence warnings during deferred probe

On Mon, 27 Apr 2020, Mark Brown wrote:

On Mon, Apr 27, 2020 at 09:48:32AM +0200, Marek Szyprowski wrote:

...

Don't confuse user with meaningless warning about the failure in getting clocks in case of deferred probe.

...

if (ret < 0) {

• dev_err(&pdev->dev, "Failed to get clocks: %d\n", ret);
  

• if (ret != -EPROBE_DEFER)
  

• 	dev_err(&pdev->dev, "Failed to get clocks: %d\n", ret);
  

This completely eliminates the diagnostics which means that if the clock isn't there the user is a bit stuck trying to work out what's missing. There should still be a diagnostic.

The driver won't defer forever though. The final pass should fail with a different error. At which point the error will be released to the system log, no?