On Tue, May 20, 2014 at 11:21:08PM +0200, Lars-Peter Clausen wrote:
On 05/20/2014 09:16 PM, Tomasz Figa wrote:
Still, I'm not too experienced with ALSA and ASoC, so I might be wrong. Mark, what do you think about this?
Given that there is a patch[1] which removes the whole file I think we can stop the discussion about this patch here.
But for the record, substream will never ever be NULL in this function. prtd might be though if the DMA completion callback races against the closing of the PCM stream.
Yeah, what Lars said - obviously the patch removing the driver is more comprehensive!
For the record it's very helpful to be specific about what the problem being addressed is in the changelog, if it's not obvious what the bug that's being fixed is that'll slow things down. Please also use subject lines appropriate for the subsystem, it will help your patch get noticed.