Dear Thomas,
2015-02-27 15:03 GMT+01:00 Thomas Petazzoni thomas.petazzoni@free-electrons.com:
Dear Marcin Wojtas,
On Thu, 26 Feb 2015 10:05:08 +0100, Marcin Wojtas wrote:
Given that this PLL layout is most likely 38x specific, I'd just put it into drivers/clk/mvebu/armada-38x.c.
Audio PLL setting consist of 3 independent registers. Adjacent to them there are same regs for setting TDM PLL, however I doubt telephony is going to be supported in foreseeable future (if ever).
We might be supporting TDM in the future. However, I see that the TDM PLL registers are nicely grouped together, and so are the audio PLL registers. So maybe we can simply have a driver to handle the audio PLL registers for now, and if needed in the future, add another driver for the TDM PLL.
I've got very fresh experience of adding TDM support for A38x, it definitely would require longer discussion.
I also have strong suspicion that it looks the same in a39x - Thomas, can you take a look into spec and confirm?
As far as I can see there is no audio support and no TDM support in Armada 39x, and there those TDM PLL and audio PLL registers do not exist.
Given all the facts, do you think that drivers/clk/mvebu/armada-38x.c is a right place for adding this PLL setting support?
Best regards, Marcin