Re: [alsa-devel] [PATCH 06/34] don't use __devexit_p to wrap hal2_remove

On Thu, Oct 01, 2009 at 10:36:59AM +0200, Takashi Iwai wrote:

At Thu, 1 Oct 2009 10:28:10 +0200, Uwe Kleine-König wrote:

...

The function hal2_remove is defined using __exit, so don't use __devexit_p but __exit_p to wrap it.

I think it's the other way round. We should replace __exit with __devexit. Ditto for sound/mips/sgio2audio.c.

Actually both ways are possible. I choosed the alternative that doesn't add bloat to the kernel. The cost is that the device isn't hotplugable, but you can still unload the module to unbind the driver.

I don't care much, but prefer slightly my approach as changing the patch is work for me :-)

Best regards Uwe