31 Oct
2014
31 Oct
'14
5:44 a.m.
On Thu, Oct 30, 2014 at 06:06:09PM +0000, Mark Brown wrote:
On Thu, Oct 30, 2014 at 10:38:55AM +0530, Vinod Koul wrote:
- ret = sst_prepare_and_post_msg(sst, SST_TASK_ID_MEDIA, IPC_CMD,
IPC_PREP_D3, PIPE_RSVD, 0, NULL, NULL,true, true, false, true);- if (ret < 0) {
dev_err(sst->dev, "not suspending FW!!!");return -EIO;Better to print and pass back the actual error code we got.
OK
- dev_info(dev, "runtime_suspend called\n");
- if (ctx->sst_state == SST_RESET) {
Drop this down to a dev_dbg() or remove it please (and some others later on).
Oh yes, did remove some will celanup others
dev_dbg(dev, "LPE is already in RESET state, No action");Missing \n.
return 0;- }
- /*save fw context*/
/* Upstream comment style please */
Sure will check these
Thanks
--
~Vinod