At Thu, 22 Oct 2009 17:25:06 -0300, Rafael Ignacio Zurita wrote:
This is a port of the sound/oss/sh_dac_audio.c driver. The driver uses an on-chip 8-bit D/A converter, which has a speaker connected to one of its channels, found in several ancient HP machines. For interrupts it uses a high-resolution timer (hrtimer). Tested on SH7709 based hp6xx (HP Jornada 680/690 and HP Palmtop 620lx/660lx).
Also, since OSS Emulation works, the old OSS sound/oss/sh_dac_audio.c driver would be obsolete soon, and it could be removed.
Changes since V2:
- renamed include/sound/dac_audio.h to include/sound/sh_dac_audio.h
Changes since V1:
- moved the platform device code into board code.
- dropped dac_audio_sync(), since that code is not needed (it was inherited of the old oss driver).
- rewrote the code with style problems.
Signed-off-by: Rafael Ignacio Zurita rizurita@yahoo.com
Thanks for the patch.
--- /dev/null +++ b/include/sound/sh_dac_audio.h @@ -0,0 +1,21 @@ +/*
- SH_DAC specific configuration, for the dac_audio platform_device
- Copyright (C) 2009 Rafael Ignacio Zurita rizurita@yahoo.com
- This program is free software; you can redistribute it and/or modify it
- under the terms of the GNU General Public License version 2 as published
- by the Free Software Foundation.
- */
+#ifndef __INCLUDE_SH_DAC_AUDIO_H +#define __INCLUDE_SH_DAC_AUDIO_H
+struct dac_audio_pdata {
- int buffer_size;
- int channel;
- void (*start)(struct dac_audio_pdata *pd);
- void (*stop)(struct dac_audio_pdata *pd);
+};
+#endif /* __INCLUDE_SH_DAC_AUDIO_H */
Isn't it better to include this piece into mach/hp6xx.h or so? Since it's pretty specific to the platform, it's not necessarily in the common sound include path.
snd_sh_dac_audio.c looks good to me. One little concern is the module name. Other ALSA modules are named as snd-xxx (no underscore), so it's better to follow that. Also a file name should be without snd_ prefix.
thanks,
Takashi