Hi Clemens,
On 12.07.2012 16:29, Clemens Ladisch wrote:
Daniel Mack wrote:
In endpoint.c, bail out earlier in case the stream is stopped. ... @@ -350,7 +350,8 @@ static void snd_complete_urb(struct urb *urb) urb->status == -ENODEV || /* device removed */ urb->status == -ECONNRESET || /* unlinked */ urb->status == -ESHUTDOWN || /* device disabled */
ep->chip->shutdown)) /* device disconnected */
ep->chip->shutdown) || /* device disconnected */!test_bit(EP_FLAG_RUNNING, &ep->flags))Is this really needed? The URBs will be unlinked at the same time.
This just brings the code in sync with what we had before. If URBs are just unlinked but not killed, they will return with data payload, and in case of implicit feedback streams, the retire code could issue new output packets. Might be I overlooked a reason why that could never happen, but even if I did, the check here doesn't hurt, right?
Daniel