On Mon, Jan 03, 2011 at 11:00:04AM +0530, Koul, Vinod wrote:
This looks mostly OK, but you probably want to run it through checkpatch.pl. For quite a few of the debug prints you've got here you're replicating stuff that's in the core as standard - if you turn on debug logs from the core you should get equivalent logging.
Yes we have run checkpatch. Currently yes we have quite a few logs, we will
There's quite a few places where there are coding style issues, in general if your code doesn't look like other kernel code that's a problem. One of the most frequent issues was that you weren't using spaces around /* and */.
remove them later when we add the capture, jack detection etc. It would be nice to have these logs on.
It would be good if you could at least make the logging consistent with the rest of the subsystem, and as I say avoid replicating logging which is already provided by the subsystem. The point is not that this stuff exists, the point is that it's replicating a facility that's already there.