Hi Krzysztof
On 30/12/2022 10:34, wangweidong.a@awinic.com wrote:
From: Weidong Wang wangweidong.a@awinic.com
Add a DT schema for describing Awinic AW883xx audio amplifiers. They are controlled using I2C.
Signed-off-by: Weidong Wang wangweidong.a@awinic.com
.../bindings/sound/awinic,aw883xx.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml
diff --git a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml new file mode 100644 index 000000000000..b677427ebcd1 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Awinic AW883xx Smart Audio Amplifier
+maintainers:
- Stephan Weidong Wang wangweidong.a@awinic.com
+description:
- The Awinic AW883XX is an I2S/TDM input, high efficiency
- digital Smart K audio amplifier with an integrated 10.25V
- smart boost convert.
+allOf:
- $ref: dai-common.yaml#
+properties:
- compatible:
- const: awinic,aw883xx
Now the question what does "xx" stand for? I cannot find such product on awinic website: https://www.awinic.com/En/Index/queryAll/wd/aw883xx.html
xx represents our company's aw88394 and aw88395 chips,Aw88395 chips can be found on https://www.awinic.com/cn/detail/index/catid/229/id/48/title/AW88395CSR.html The aw88394 chip will be available on the website in the near future.
- reg:
- maxItems: 1
- reset-gpios:
- maxItems: 1
Why there is no sound-dai-cells?
I'll add sound-dai-cells in patch v8
- sound-name-prefix: true
Drop it.
I will modify it on patch v8
+required:
- compatible
- reg
- reset-gpios
+additionalProperties: false
Instead: unevaluatedProperties: false
unless this is not a codec and sound-dai-cells cannot be used?
I will modify it on patch v8
+examples:
- |
- i2c {
#address-cells = <1>;#size-cells = <0>;audio-codec@34 {compatible = "awinic,aw883xx";reg = <0x34>;reset-gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions).
I will modify it on patch v8
Best regards, Weidong Wang