Re: [PATCH v3] ASoC: qcom: Add four speaker support on MI2S secondary

Quoting Srinivasa Rao Mandadapu (2021-06-09 06:30:39)

diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index c62d2612e8f5..aff39c9f6326 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -29,6 +29,15 @@ #define LPASS_CPU_I2S_SD0_1_2_MASK GENMASK(2, 0) #define LPASS_CPU_I2S_SD0_1_2_3_MASK GENMASK(3, 0)

+/*

• • Channel maps for Quad channel playbacks on MI2S Secondary
• */

+static struct snd_pcm_chmap_elem lpass_quad_chmaps[] = {

Can this be const?

•           { .channels = 4,
  

•             .map = { SNDRV_CHMAP_FL, SNDRV_CHMAP_RL,
  

•                           SNDRV_CHMAP_FR, SNDRV_CHMAP_RR } },
  

•           { }
  

+}; static int lpass_cpu_init_i2sctl_bitfields(struct device *dev, struct lpaif_i2sctl *i2sctl, struct regmap *map) {