Re: [alsa-devel] Build regressions/improvements in v3.0-rc7 (sound/isa/)

On Wed, 13 Jul 2011 21:33:30 +0200 Geert Uytterhoeven wrote:

• src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_disable': => 544
• src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_pointer': => 302
• src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_program': => 244
• src/sound/isa/es1688/es1688_lib.c: error: implicit declaration of function 'snd_dma_pointer': => 509
• src/sound/isa/es1688/es1688_lib.c: error: implicit declaration of function 'snd_dma_program': => 417
• src/sound/isa/gus/gus_dma.c: error: implicit declaration of function 'snd_dma_disable': => 177
• src/sound/isa/gus/gus_dma.c: error: implicit declaration of function 'snd_dma_program': => 79
• src/sound/isa/gus/gus_pcm.c: error: implicit declaration of function 'snd_dma_pointer': => 619
• src/sound/isa/gus/gus_pcm.c: error: implicit declaration of function 'snd_dma_program': => 591
• src/sound/isa/sb/sb16_main.c: error: implicit declaration of function 'snd_dma_pointer': => 456
• src/sound/isa/sb/sb16_main.c: error: implicit declaration of function 'snd_dma_program': => 276
• src/sound/isa/sb/sb8_main.c: error: implicit declaration of function 'snd_dma_pointer': => 425
• src/sound/isa/sb/sb8_main.c: error: implicit declaration of function 'snd_dma_program': => 172
• src/sound/isa/sscape.c: error: implicit declaration of function 'snd_dma_program': => 481
• src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_disable': => 1695
• src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_pointer': => 1160
• src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_program': => 1025

All of these source files do #include <sound/core.h>, but these missing/implicit functions are conditional:

#ifdef CONFIG_ISA_DMA_API #define DMA_MODE_NO_ENABLE 0x0100

void snd_dma_program(unsigned long dma, unsigned long addr, unsigned int size, unsigned short mode); void snd_dma_disable(unsigned long dma); unsigned int snd_dma_pointer(unsigned long dma, unsigned int size); #endif

so should these drivers all depend on ISA_DMA_API ? or should only pieces of each driver depend on ISA_DMA_API ?

--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***