Sorry, I missed to add alsa-devel@alsa-project.org on Cc. ________________________________________ From: Timur Tabi timur@tabi.org Sent: Thursday, September 18, 2014 3:37 PM To: Nicolin Chen Cc: Estevam Fabio-R49496; broonie@kernel.org; Xiubo Li-B47053 Subject: Re: [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property
On 09/18/2014 01:32 PM, Nicolin Chen wrote:
On Thu, Sep 18, 2014 at 03:11:17PM -0300, Fabio Estevam wrote:
There is no need to use 'i2s-slave' property, since master/slave configuration are passed via machine layer.
This change does not break existing users because they do check for slave mode inside sound/soc/fsl/mpc8610_hpcd.c/p1022_ds.c and p1022_rdk.c
Besides this change, I'm wondering if we can take a further step to drop this entire property from Device Tree binding document as newer platforms may no long need this property in their DT bindings.
I think the property is necessary if anyone takes a P1022 or MPC8610 and uses it in a platform that doesn't support i2s-slave. But currently, the code doesn't support anything else. So technically, we could remove it, and if anyone does want to support another configuration, he will have to add that support the "new" way.