On 09/11/2007 12:40 AM, Krzysztof Helt wrote:
This patch replaces long msleeps in waiting loops with schedule_timeout() calls.
Hope you'll not detest me for getting on your case so much, but...
First, yes, attachments are good as far as I'm concerned, but could you make them plain text attachments? They are now Base64 which means that at least with my "casual mailer" (Thunderbird) I need to save the patch and can only then look at it.
Second -- not schedule_timeout_interruptible? A plain schedule_timeout won't work, as you first need to __set_current_state or it will not schedule. That is, schedule_timeout_interruptible or _uniterruptible and with the latter, the loop wouldn't make much sense anymore as it's just going to sleep for the full 250 ms directly.
Rene.