At Tue, 26 May 2015 09:44:36 +0530, Vinod Koul wrote:
On Mon, May 25, 2015 at 01:58:58PM +0200, Takashi Iwai wrote:
Merging this without the codec driver would be rather confusing for users, since it gives a conflicting driver that doesn't work at all. I suppose that the merge should be pending until the complete implementation of ASoC HDA.
Well users wont notice till we have a machine driver which selects this driver. That is why machine driver will come last and needs to be merged only after controller and codec drivers are merged for end users to notice
We still don't provide a way to lead to the right driver. With your patch 5, it creates another SKL PCI driver that conflicts with the existing driver entry of snd-hda-intel. So, at this moment, it just give a conflict for non-working driver, and it's not good to leave so unless the complete driver set is provided in a week or so.
Hi Takashi,
You are right in that but the point is that user cannot select this driver
+config SND_SOC_INTEL_HDA_SKYLAKE
tristateselect SND_SOC_HDA_COREhelpSay Y here to include support for ASoC Intel "High DefinitionAudio" (Skylake) and its compatible devices.So unless someone selects this symbol (machine driver) it wont be built for anyone (expect you and me to test :D ) and wont conflict. Or did I miss something ?
Distros tend to select all possible options, especially if it can be built as a module. Even if it's written in the help text, not everybody reads it.
Also anyway I will add the flag in this driver as follow on to disable registering this device so that users don't see this device getting registered, unless we have complete story merged.
Yeah, we should prepare some way before the actual conflict is seen.
thanks,
Takashi