Re: [alsa-devel] [PATCH] ess1688: fix OPL3 port setting (2nd rev)

30 Jan 2009


      At Fri, 30 Jan 2009 09:55:28 +0100,
Krzysztof Helt wrote:
...
@@ -143,13 +146,19 @@ static int __devinit snd_es1688_probe(struct device *dev, unsigned int n)
   sprintf(card->longname, "%s at 0x%lx, irq %i, dma %i", pcm->name,
   	chip->port, chip->irq, chip->dma8);

if (snd_opl3_create(card, chip->port, chip->port + 2,
	OPL3_HW_OPL3, 0, &opl3) < 0)


dev_warn(dev, "opl3 not detected at 0x%lx\n", chip->port);


else {
error =	snd_opl3_hwdep_new(opl3, 0, 1, NULL);


if (error < 0)


	goto out;




if (fm_port[n] != SNDRV_AUTO_PORT)
fm_port[n] = port[n];	/* share the same port */



It should be
if (fm_port[n] == SNDRV_AUTO_PORT)
Takashi

    

Takashi Iwai