Re: [PATCH 06/18] arm64: dts: renesas: beacon: Configure Audio CODEC clocks

Hi Adam,

CC alsa-devel

On Sun, Dec 13, 2020 at 7:38 PM Adam Ford aford173@gmail.com wrote:

With the newly added configurable clock options, the audio CODEC can configure the mclk automatically. Add the reference to the versaclock. Since the devices on I2C5 can communicate at 400KHz, let's also increase that too

Signed-off-by: Adam Ford aford173@gmail.com

Thanks for your patch!

--- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi @@ -424,13 +424,15 @@ &i2c0 {

&i2c5 { status = "okay";

•   clock-frequency = <100000>;
  

•   clock-frequency = <400000>;
    pinctrl-0 = <&i2c5_pins>;
    pinctrl-names = "default";
  
    codec: wm8962@1a {
            compatible = "wlf,wm8962";
            reg = <0x1a>;
  

•           clocks = <&versaclock6_bb 3>;
  

•           clock-names = "mclk";
  

While the driver does get the (nameless) clock, the DT bindings lack any mention of a clocks property. It would be good to update the bindings.

Note that arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi and arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi (both by your hand) use "xclk" instead of "mclk"?

            DCVDD-supply = <&reg_audio>;
            DBVDD-supply = <&reg_audio>;
            AVDD-supply = <&reg_audio>;

Gr{oetje,eeting}s,

Geert