Re: [alsa-devel] [PATCH] ASoC: rt274: Disable jack report IRQ with disabling jack

On Tue, Nov 12, 2019 at 02:02:37PM +0100, Pawel Harlozinski wrote:

/* Disable jack detection */
regmap_update_bits(rt274->regmap, RT274_EAPD_GPIO_IRQ_CTRL,
			RT274_IRQ_EN, RT274_IRQ_DIS);

• disable_irq(rt274->i2c->irq);
  

  return 0;

Shouldn't the register update above be suppressing interrupts? disable_irq() is a bit of a hammer and interferes with things like possible share use.