Re: [alsa-devel] [PATCH v2 1/2] ASoC: SOF: Add Comet Lake PCI IDs

Minor nit-picks below. The Kconfig would work but select CANNONLAKE even if you don't want it.

+config SND_SOC_SOF_COMETLAKE_LP

• tristate
• select SND_SOC_SOF_CANNONLAKE

This should be select SND_SOF_SOF_HDA_COMMON

• help

•  This option is not user-selectable but automagically handled by
  

•  'select' statements at a higher level
  

+config SND_SOC_SOF_COMETLAKE_LP_SUPPORT

• bool "SOF support for CometLake-LP"
• help

•  This adds support for Sound Open Firmware for Intel(R) platforms
  

•  using the Cometlake-LP processors.
  

•  Say Y if you have such a device.
  

•  If unsure select "N".
  

+config SND_SOC_SOF_COMETLAKE_H

• tristate
• select SND_SOC_SOF_CANNONLAKE

This should be select SND_SOF_SOF_HDA_COMMON

• help

•  This option is not user-selectable but automagically handled by
  

•  'select' statements at a higher level
  

+config SND_SOC_SOF_COMETLAKE_H_SUPPORT

• bool "SOF support for CometLake-H"
• help

•  This adds support for Sound Open Firmware for Intel(R) platforms
  

•  using the Cometlake-H processors.
  

•  Say Y if you have such a device.
  

•  If unsure select "N".