4 Jul
2008
4 Jul
'08
7:57 p.m.
On Fri, Jul 04, 2008 at 05:09:36PM +0200, Takashi Iwai wrote:
(BTW, at the next time, a bit more patch description would be helpful. For example, in this case, it's actually not about warning but the behavior of strict_strtoul() that resets the value, if I understand correctly.)
It is a warning fix - I was passing the wrong type of variable to strict_strtoul(), though on most architectures int and long are the same in memory so the behaviour before and after the change is identical. The fix is to pass a temporary variable of the correct type in and then assign the result to pop_time rather than passing pop_time in directly.