Re: [PATCH] ALSA: line6: Improve poor error handling in line6_init_cap_control

On Tue, May 25, 2021 at 09:05:13AM +0200, Takashi Iwai wrote:

Those resources are freed in the common destructor of the card instance, line6_destruct(),

Oh my god, I missed line6_destruct.

at disconnect callback, so it's redundant to release them here; even worse, since you haven't re-initialize with NULL, this change would lead to double-free.

Yes then it can cause double-free..

thanks,

Takashi

I made a mistake, I'm so sorry to take your time...

Thanks, Hyeonggon