Am Dienstag, 17. Mai 2016, 11:36:23 schrieb Heiko Stuebner:
Am Dienstag, 17. Mai 2016, 10:14:55 schrieb Enric Balletbo Serra:
Hi Heiko,
2016-05-16 0:06 GMT+02:00 Heiko Stuebner heiko@sntech.de:
Am Montag, 9. Mai 2016, 12:46:34 schrieb Enric Balletbo i Serra:
Set i2s block to "okay", add sound node for max98090 with gpios for HP and Mic detect and pinctrl, and add a max98090 device and ts3a227e to the correct i2c bus.
Signed-off-by: Enric Balletbo i Serra enric.balletbo@collabora.com
I only got a "applied" reply from Marks scripts for patch 3/5, so only today saw that all 3 actually got applied.
Anyway, I've applied this to my dts32-branch for 4.8 now [0] with some modifications regarding
- the commit subject+message
- ordering
- io_domains access (via the phandle now)
- regulator suspend property
so maybe take a look and holler if you see a mistake.
The changes looks good to me, thanks.
I was able to get audio over the headphones (so definitly an improvement), but so far not over the built-in speakers. Did you need to do something special in the configuration for this?
I added an UCM file [1] to my setup to test this and tested as follows (you can also use alsamixer but as you know this is not safe though ;) )
# enable the speaker at bootup: alsaucm -c ROCKCHIP-I2S set _verb HiFi # set speaker to half loudness: amixer set Speaker 50% # play something aplay music.wav # enable headphones (disable speaker): alsaucm -c ROCKCHIP-I2S set _verb HiFi set _enadev Headphone # set headphones to half loudness: amixer set Headphone 50% # play something aplay music.wav # disable headphones (enable speaker): alsaucm -c ROCKCHIP-I2S set _verb HiFi set _disdev Headphone
woohoo ... sound on the speakers :-D
one thing I'm not sure about is the naming though.
The ucm profiles most likely are board-specific and looking at the other alsa ucm subdirs, they really are named after their boards (like daisy-i2s for some exynos chromebooks). Hogging ROCKCHIP-I2S for veyron chromebooks seems wrong especially wrt. other Rockchip devices. Shouldn't this be named VEYRON-I2S or so instead - same on the kernel side probably.
Heiko