Re: [alsa-devel] [PATCH] ALSA: use list_move_tail instead of list_del/list_add_tail

At Wed, 5 Sep 2012 15:00:15 +0800, Wei Yongjun wrote:

From: Wei Yongjun yongjun_wei@trendmicro.com.cn

Using list_move_tail() instead of list_del() + list_add_tail().

Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn

Applied this one, too. Thanks.

Takashi

---

sound/pci/emu10k1/memory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/emu10k1/memory.c b/sound/pci/emu10k1/memory.c index 0a43662..1dce0a39 100644 --- a/sound/pci/emu10k1/memory.c +++ b/sound/pci/emu10k1/memory.c @@ -263,8 +263,8 @@ int snd_emu10k1_memblk_map(struct snd_emu10k1 *emu, struct snd_emu10k1_memblk *b spin_lock_irqsave(&emu->memblk_lock, flags); if (blk->mapped_page >= 0) { /* update order link */

• list_del(&blk->mapped_order_link);
  

• list_add_tail(&blk->mapped_order_link, &emu->mapped_order_link_head);
  

• list_move_tail(&blk->mapped_order_link,
  

• 	       &emu->mapped_order_link_head);
  

  spin_unlock_irqrestore(&emu->memblk_lock, flags); return 0; }