13 Jan
2014
13 Jan
'14
4:44 p.m.
On Mon, Jan 13, 2014 at 02:18:28PM +0100, Markus Pargmann wrote:
On Mon, Jan 13, 2014 at 12:37:21PM +0000, Mark Brown wrote:
Applied, thanks but you should really also add this compatible string to the driver.
Oh, I didn't notice that the 320aic3x driver actually has of_device_ids. I was using the 320aic3x4 driver which only defines i2c_device_id but it still matches with the compatible fields from my devicetree.
So perhaps it is better to drop this patch as it is no explicit compatible in the driver?
Or you could add the compatible string to the driver as I suggested... I don't see any reason for the device not to have a compatible string?